Skip to content

Skip HostAbortedExceptionTests when BinaryFormatter isn't supported - #70151

Merged
eerhardt merged 1 commit into
dotnet:mainfrom
eerhardt:Fix70132
Jun 2, 2022
Merged

Skip HostAbortedExceptionTests when BinaryFormatter isn't supported#70151
eerhardt merged 1 commit into
dotnet:mainfrom
eerhardt:Fix70132

Conversation

@eerhardt

@eerhardt eerhardt commented Jun 2, 2022

Copy link
Copy Markdown
Member

@eerhardt
eerhardt requested review from maryamariyan and tarekgh June 2, 2022 14:12
@ghost ghost assigned eerhardt Jun 2, 2022
@ghost

ghost commented Jun 2, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-extensions-hosting
See info in area-owners.md if you want to be subscribed.

Issue Details

Fix #70132

cc @deeprobin

Author: eerhardt
Assignees: -
Labels:

area-Extensions-Hosting
Milestone: -

@eerhardt

eerhardt commented Jun 2, 2022

Copy link
Copy Markdown
Member Author

/azp run runtime-extra-platforms

@azure-pipelines

azure-pipelines Bot commented Jun 2, 2022

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@deeprobin

deeprobin commented Jun 2, 2022

Copy link
Copy Markdown
Contributor

Oh I forgot that there are platforms without BinaryFormatter.

Thank you for fixing this 😅

PR LGTM

danmoseley
danmoseley approved these changes Jun 2, 2022
View reviewed changes

@danmoseley danmoseley left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this mac specific?

@eerhardt

eerhardt commented Jun 2, 2022

Copy link
Copy Markdown
Member Author

Why was this mac specific?

"mac" was a bit of a loose term. It was failing on ios, tvos, maccatalyst.

runtime/src/libraries/Common/tests/TestUtilities/System/PlatformDetection.cs

Line 91 in bbb18ae

public static bool IsBinaryFormatterSupported => IsNotMobile && !IsNativeAot;

@eerhardt

eerhardt commented Jun 2, 2022

Copy link
Copy Markdown
Member Author

runtime (Libraries Test Run release coreclr Linux x64 Debug) - System.Net.Http.Functional.Tests failure
runtime-extra-platforms (Build iOSSimulator x64 Release AllSubsets_Mono) - Microsoft.Extensions.Configuration.Functional.Tests failure
runtime-extra-platforms (Build tvOS arm64 Release AllSubsets_Mono) -System.Text.RegularExpressions.Unit.Tests failure
runtime-extra-platforms (Build tvOSSimulator x64 Release AllSubsets_Mono) - System.Threading.Tests failure

None of these are hosting tests, so this solves the issue.

@eerhardt
eerhardt merged commit b09ae1a into dotnet:main Jun 2, 2022
@eerhardt
eerhardt deleted the Fix70132 branch June 2, 2022 17:58
@ghost ghost locked as resolved and limited conversation to collaborators Jul 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@tarekgh tarekgh tarekgh approved these changes
@maryamariyan maryamariyan Awaiting requested review from maryamariyan
+2 more reviewers
@danmoseley danmoseley danmoseley approved these changes
@deeprobin deeprobin deeprobin approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@eerhardt eerhardt

Labels

area-Extensions-Hosting

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Microsoft.Extensions.Hosting.Unit.Tests.HostAbortedExceptionTests doesn't work on OSX

4 participants

@eerhardt @deeprobin @danmoseley @tarekgh